search: Stop special-casing GNOME Settings on search

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1282#note_1617502

From the chat:
<aday> i think it's fine to allow people to disable settings search.
<aday> the issue i see here is that the shell doesn't follow the search
results order. settings is always at the top of the results list
<aday> if settings search is to appear in the list, then that should
work as you'd expect

We are also removing the special-casing in the GNOME Settings side,
see https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1555

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2584>

diff --git a/js/ui/remoteSearch.js b/js/ui/remoteSearch.js
index cef6f9cd3502a0e95486fe973fcbaac3716b7697..592dfe199b936bc0aef5b92ee568aa594d0105c7 100644 (file)
--- a/js/ui/remoteSearch.js
+++ b/js/ui/remoteSearch.js
@@ -144,9 +144,6 @@ function loadRemoteSearchProviders(searchSettings) {
 
     let sortOrder = searchSettings.get_strv('sort-order');
 
-    // Special case gnome-control-center to be always active and always first
-    sortOrder.unshift('org.gnome.Settings.desktop');
-
     const disabled = searchSettings.get_strv('disabled');
     const enabled = searchSettings.get_strv('enabled');